I can't enter information from form to database

Question

`I am trying to enter data to database from a registration form but it seems not working and I think I did the right coding I'm not sure where I did wrong I read code by code and all the database I created did follow .

<form method='post' action='login.php'>
<table width='400' border='5' align='CENTER'>

<tr>
<td><h1>Registration</h1></td>

</tr>

<tr>
<td>User Name:</td>
<td><input type='text' name='name'/></td>
</tr>

<tr>
<td>Password:</td>
<td><input type='password' name='pass'/></td>
</tr>
<tr>
<td>Email:</td>
<td><input type='text' name='email'/></td>
</tr>
<tr>
<td><input type='submit' name='register' value='register'/></td>

</tr>

</table>
</form>

<?php
    $connect=mysql_connect("localhost","root","");
    $db_selected = mysql_select_db("users_db", $connect); 
    if(isset($_POST['submit'])){

    $users_name = $_POST['name'];
    $users_pass = $_POST['pass'];
    $users_email = $_POST['email'];

    if($users_name==''){
    echo "<script>alert('Please enter your Username')</script>";
        exit();
    }

    if($users_pass==''){
    echo "<script>alert('Please enter your password')</script>";
        exit();
    }

    if($users_email==''){
    echo "<script>alert('Please enter your email')</script>";
        exit();
    }

    $check_email="select*from 
    users where 
    users_email='$users_email'";

    $run = 
    mysql_query($check_email) or
    die(mysql_error());


    if(mysql_num_rows($run)>0){

    echo"<script>alert('Email $users_email 
    is already exist in our databse, please try another 
    one')</script>";  exit();
    }


    $query = "insert into users 
    (users_name,users_pass,users_email) values('
    $users_name','$users_pass','$users_email')";


    { 
        $result = mysql_query($query) 
        or die(mysql_error());
    }

    echo"<script>alert
    window.open('','_self')</script>";
    }

?>

**Danger**: You are using [an **obsolete** database API](http://stackoverflow.com/q/12859942/19068) and should use a [modern replacement](http://php.net/manual/en/mysqlinfo.api.choosing.php). You are also **vulnerable to [SQL injection attacks](http://bobby-tables.com/)** that a modern API would make it easier to [defend](http://stackoverflow.com/questions/60174/best-way-to-prevent-sql-injection-in-php) yourself from. — Quentin, Oct 17 '13 at 21:38
Have you tried `echo`ing `$query` and running the final query in phpMyAdmin or whatever other database tools you have to make sure it is correct? — Ken Herbert, Oct 17 '13 at 21:47
I don't see any `INSERT` statements. So no data will ever go into your DB — Machavity, Oct 17 '13 at 21:48
Do you really have a newline before `$users_name` in the query? — Barmar, Oct 17 '13 at 21:51
In the $check_email query you should add spaces around the *. — Lajos Veres, Oct 17 '13 at 21:53
You have to tell us about the HTML form you use to submit the data. Where it is in relation to the PHP page and what's its action attribute and method attribute. — SaidbakR, Oct 17 '13 at 22:09

score 1 · Answer 1 · answered Oct 17 '13 at 21:57

1

Change the initial assignments to:

$users_name = mysql_real_escape_string($_POST['name']);
$users_pass = mysql_real_escape_string($_POST['pass']);
$users_email = mysql_real_escape_string($_POST['email']);

to avoid problems with special characters in the fields, as well as to protect against SQL injection.

Change the insert query to:

$query = "insert into users (users_name,users_pass,users_email)
          values('$users_name','$users_pass','$users_email')";

You had an extraneous newline and spaces before $users_name, so these were being inserted into the database.

answered Oct 17 '13 at 21:57

Barmar

596,455
48
393
495

i tried but still the same result no database are entered from the form – dean012 Oct 17 '13 at 22:08
1

What happens if you `echo $query` and then run it by hand in PhpMyAdmin? – Barmar Oct 17 '13 at 22:11
Yes I think that data does not delivered well to the PHP. I think the form does not has get attribute, so $_POST does not receive any data. – SaidbakR Oct 17 '13 at 22:17
i added echo $query = "insert into users (users_name,users_pass,users_email) values('$users_name','$users_pass','$users_email')"; – dean012 Oct 17 '13 at 22:17
still the same no data entered – dean012 Oct 17 '13 at 22:18
Check Your HTML form again. – SaidbakR Oct 17 '13 at 22:18
That should display the query SQL. What does it display? – Barmar Oct 17 '13 at 22:18
You just has to `echo $query;` – SaidbakR Oct 17 '13 at 22:19
this is my html coding – dean012 Oct 17 '13 at 22:21
3

Don't try to put HTML in the comment, update your question – Barmar Oct 17 '13 at 22:21
i cant post the coding here – dean012 Oct 17 '13 at 22:22
Well, what is the name of your php file that execute the PHP code you regarded? – SaidbakR Oct 17 '13 at 22:25
http://localhost/registration.php – dean012 Oct 17 '13 at 22:27
Wow, this is your mistake. You have to check again how HTML forms works. http://www.w3schools.com/html/html_forms.asp – SaidbakR Oct 17 '13 at 22:28
i dont see any mistake? – dean012 Oct 17 '13 at 22:32
1

You have to know what's the meaning of `action` attribute of an HTML form! – SaidbakR Oct 17 '13 at 22:35
Username: thats what i did – dean012 Oct 17 '13 at 22:44
– dean012 Oct 17 '13 at 22:45
`action='registration.php'` – SaidbakR Oct 17 '13 at 22:46
i change it but still not workng – dean012 Oct 17 '13 at 22:49
Change your PHP to just `` and see if that works. I want to make sure you're getting into the right script. – Barmar Oct 17 '13 at 23:49
yup tried that but nor working it also came out this – dean012 Oct 18 '13 at 01:02
This is the PHP script – dean012 Oct 18 '13 at 01:03
1

Then I can't explain why the original script isn't working. With all the changes we suggested, it should work. You must not be copying them properly. – Barmar Oct 18 '13 at 01:04

I can't enter information from form to database

1 Answers1

Linked

Related