click event not working in IE7 in jquery

Question

I want to add one function dynamically on a tag which is working fine on all browser except IE7.

<head>
<script type="text/javascript" src="jquery-1.8.3.js"></script>
<script type="text/javascript">
function show(num){
if(num==1){
$('#one').removeAttr('onclick')
$('#two').attr('onclick','show(1)')
alert(0)
}}
</script>
</head>
<body>
<a href="javascript:void(0)" onclick="show(1)" id="one">one</a>
<a href="javascript:void(0)" id="two">two</a>
</body>
</html>

@DadoJerry It won't even work in 8 on my machine. 9 or higher. Chrome ftw. — War10ck, Jun 27 '13 at 13:42
Here is a related [jQuery attr('onclick') Problem][1]. [1]: http://stackoverflow.com/questions/5781616/jquery-attronclick-problem — frkk, Jun 27 '13 at 13:44
`$('#two').attr('onclick','show(1)')` is *not* how you attach an event handler. — Rocket Hazmat, Jun 27 '13 at 13:45
It is working fine but in all browser but what is problem with ie7 — Carlos, Jun 27 '13 at 13:49
@amit It may have worked, but it wasn't the correct way to do it. jQuery provides handler functions for just this purpose. Check out some of the answers below to see how jQuery handlers can be applied in this situation. — War10ck, Jun 27 '13 at 13:55

score 5 · Accepted Answer · answered Jun 27 '13 at 13:40

5

This is not the correct way to attach/detach event handlers. You can try using this methodology instead.

$('#one').off('click');
$('#two').click(function() { show(1); });

.click() is a wrapper function for .on('click')

answered Jun 27 '13 at 13:40

Brad M

7,689
1
19
37

I'm not sure if `.off('click')` will remove the inline `onclick` handler. – Rocket Hazmat Jun 27 '13 at 13:43
@RocketHazmat True, it most likely won't. It's not a complete solution, just a suggestion. – Brad M Jun 27 '13 at 13:44

Arun P Johny · Answer 2 · 2013-06-27T13:49:58.557

2

Since you are using jQuery, use it to register the event handlers instead of using onclick attribute

You can use .one() event register since you want to call the event handler only once instead of using .on() and .off()

jQuery(function(){
    function handler(num){
        alert(num)
    }
    $('#one').one('click', function(){
        handler(1);
        $('#two').on('click', function(){
            handler(1);
        });
    })
})

edited Jun 27 '13 at 13:49

answered Jun 27 '13 at 13:42

Arun P Johny

365,836
60
503
504

@BradM sorry it was `handler(num)` – Arun P Johny Jun 27 '13 at 13:44

score -3 · Answer 3 · edited Jun 29 '13 at 10:59

-3

As taken from http://forum.jquery.com/topic/click-not-working-for-ie7-8

I have a dead simple .click() event setup for a div with the id of nextLink. This works perfectly in all the "real" browsers.
$('#nextLink').click(function () {
       alert("nextLink here");
       });

      <div id="nextLink">Next</div>

edited Jun 29 '13 at 10:59

Bart

18,467
7
66
73

answered Jun 27 '13 at 13:44

Pruthvi Varma

3
2

2

If you do copy content, please have the decency to at least give proper attribution: http://forum.jquery.com/topic/click-not-working-for-ie7-8 – Bart Jun 27 '13 at 15:24

click event not working in IE7 in jquery

3 Answers3