UITableView with UILabel SizeToFit get mess when Scrolling

Question

Hi everyone I have problem with my tableview, i make Cell with uilabel with SizeToFit and then calculate the UILabel Height for set the cell Height everything work well except when i scrolling my tableView the text get weird like one char per line:

My TableViewVell Method is:

-(UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath
{
static NSString *CellIdentifier = @"Cell";
UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:CellIdentifier forIndexPath:indexPath];

if (cell == nil) {
    cell = [[UITableViewCell alloc] initWithStyle:UITableViewCellStyleDefault reuseIdentifier:CellIdentifier];
    cell.accessoryType = UITableViewCellAccessoryDisclosureIndicator;
}


UILabel *label = (UILabel *)[cell viewWithTag:1];
label.text = [someArray objectAtIndex:indexPath.row];
// Set the UILabel to fit my text;
messageLabel.lineBreakMode = UILineBreakModeWordWrap;
messageLabel.numberOfLines = 0;
[messageLabel sizeToFit];


return cell;   
}

The Cell Height stay in the correct Size the problem only with the UILabel ... this the result when i load the view:

First screenshot

And this is after i start scroll the TableView:

Second screenshot

Any Help???

What is messageLabel and is it different than the label one line above — Zen, Jun 05 '13 at 21:35
Where did you create the cell's view. You might want to set label's lineBreakMode property there only. — Zen, Jun 05 '13 at 21:37
awooo sorry i fixed it, i just changed the names to make it simple to read — Dekel Maman, Jun 05 '13 at 22:15
I'm Using Storyboard so i create it there and using [cell ViewWithTag:1] — Dekel Maman, Jun 05 '13 at 22:16
@DekelMaman See the [revisions history](http://stackoverflow.com/posts/16949576/revisions) — Lukas Spieß, May 10 '14 at 20:28
You could click the link in my comment above or in general click on the "edited $date at $time" link under your question. — Lukas Spieß, May 10 '14 at 20:34
You can't if it has been upvoted or has accepted answers or answers that have been upvoted. — Lukas Spieß, May 10 '14 at 20:56

score 20 · Answer 1 · edited Jan 09 '16 at 14:26

20

The method sizeToFit respects the width of the frame and adjust the height. And table view cell reuse the cells. Combining those two behaviors can cause the issue you described.

One of your label, which is very short in content (e.g. in the 4th cell with the word "jio"), is resized with sizeToFit and the resulting width is smaller than the original width you intended.

After that, table view reuse the cell and sizeToFit still respects the small width calculated from previous call of sizeToFit.

Solutions:

1) set the width of the frame to your original intended label width everytime before you call sizeToFit:

CGRect frame = messageLabel.frame;
frame.size.width = 100.0; //you need to adjust this value 
messageLabel.frame = frame;

2) use your row height calculation and set the frame height instead. No need to use sizeToFit.

edited Jan 09 '16 at 14:26

Meet Doshi

3,983
10
35
76

answered Jun 05 '13 at 22:42

Valent Richie

5,176
1
17
21

Getting this Error: Initializing 'CGRect *' (aka 'struct CGRect *') with an expression of incompatible type 'CGRect' (aka 'struct CGRect') On the row CGRect *frame = messageLabel.frame; – Dekel Maman Jun 05 '13 at 22:55
ok so it's working great Thanks you very much, but i was needed to you the SizeToFit after all because if I'm not using it the text fill only one row. Anyway it's work fine with this code: messageLabel.lineBreakMode = UILineBreakModeWordWrap; messageLabel.numberOfLines = 0; CGRect frame = messageLabel.frame; frame.size.width = 236.0; //you need to adjust this value messageLabel.frame = frame; [messageLabel sizeToFit]; – Dekel Maman Jun 05 '13 at 23:04
@DekelMaman Yes. For the first solution. I mentioned you need to adjust the width everytime before calling sizeToFit. No need for sizeToFit for 2nd solution. – Valent Richie Jun 05 '13 at 23:06
Check on XIB or StoryBoard - Autolayout is cheked? – Dmitry Nelepov Feb 27 '14 at 08:13

score 1 · Accepted Answer · answered Feb 23 '17 at 09:02

1

you should probably subclass your cell and clean the UILabel on

 override func prepareForReuse() {
    super.prepareForReuse()
    self.label.text = nil
}

answered Feb 23 '17 at 09:02

Rotem Doron

161
7

score 0 · Answer 3 · answered Nov 18 '14 at 11:43

0

This might help http://www.cimgf.com/2009/09/23/uitableviewcell-dynamic-height/
The approach in given reference and solution provided by @Verbumdei is nearby same.

answered Nov 18 '14 at 11:43

Yogesh Lolusare

2,094
1
21
35

score 0 · Answer 4 · answered Jan 21 '16 at 10:11

If you are not using autolayout, this can also be solved by adding a category on UIView

public func sizeToFit(constrainedSize: CGSize) -> CGSize {
  var newSize = sizeThatFits(constrainedSize)
  newSize.width = min(newSize.width, constrainedSize.width)
  newSize.height = min(newSize.height, constrainedSize.height)
  self.size = newSize
  return newSize
}

The idea is to use sizeThatFits with a constrained size to determine the size to adopt and then use the min expected width/height.

Then you just have to do something like

yourLabel.sizeToFit(self.contentView.size) // or
yourLabel.sizeToFit(CGSize(width: maxWidth, height: self.contentView.size.height))

score 0 · Answer 5 · answered Dec 07 '17 at 06:44

0

You can set preferred Width property of label. That worked for me

preferred Width

answered Dec 07 '17 at 06:44

cod3r

21
1
5

UITableView with UILabel SizeToFit get mess when Scrolling

5 Answers5

Linked