Problems with converting files to binary c++ studio 2012

Question

I'm writing a simple program that transforms a file from its original type into a binary form.

However, I'm having the following problem. The code compiles correctly but when i run it, the console window opens and never closes until i close it myself. Also, i have noticed that the longer the console window stays open, the larger the size of my newly created binary file will be. Below is my code:

#include <fstream>//to open a file

using namespace std;
int main(void){
   ifstream in("in.JPG");
   ofstream out("out.bin", ios::binary);
   double d;

   while(!in.eof()) {
      out.write((char*)&d, sizeof d);
   }
   out.close();
   in.close();

return 0;

}

score 4 · Accepted Answer · edited May 23 '17 at 12:07

4

You never read anything from in, therefore it has no chance of ever hitting eof.

Also, using eof in loop conditions is likely to lead to incorrect results, as explained in the following SO question: Why is iostream::eof inside a loop condition considered wrong?

(Generally, it's unclear what you're trying to do. .jpg is a 'binary' format, there is no sensible notion of 'converting a .jpg file to binary'.)

edited May 23 '17 at 12:07

Community

1
1

answered Feb 11 '13 at 22:57

us2012

15,457
2
41
61

Files are also a multiple of bytes, not a multiple of `double`s. – Drew Dormann Feb 11 '13 at 23:26
@Drew Well, there are text files that are lists of floating point numbers in readable ASCII format - you could read those as `double`s and then save their binary representations if you wanted... – us2012 Feb 11 '13 at 23:27
The size of a jpg file should not be assumed to be a multiple of `sizeof double`. – Drew Dormann Feb 12 '13 at 01:10
Thanks for your answer! – Nick Thomas May 11 '16 at 19:15

Problems with converting files to binary c++ studio 2012

1 Answers1