ListFragment onItemClickListener not working

Question

I'm using the tabbed layout (with swipe). Here I have 3 tabs with controlled by a SectionsPagerAdapter. Each tab is a ListFragment.

Now I want to get an event fired when one of the items in the list is clicked. I would like a listener for each tab.

Here's the code now (Which isn't working, event is not fired).

public class NyhederFragment extends ListFragment {
     public static final String ARG_SECTION_NUMBER = "section_number";
     private static final String TAG="NyhederFragment";
     private List<Item> newsItems;
     private ArrayList newsHeadlines;
     private ArrayAdapter adapter;
     private BroadcastReceiver updateReciever;

public NyhederFragment() {
}

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
        Bundle savedInstanceState) {

    ListView newsList = new ListView(getActivity());
    newsList.setLayoutParams(new LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT));
    newsList.setId(R.id.list);
    DatabaseHelper dbConn = new DatabaseHelper(getActivity());

    newsItems = dbConn.getAllItemsFromNews();
    newsHeadlines = new ArrayList();
    for(Item i : newsItems){
        newsHeadlines.add(i.getTitle());
    }

    adapter = new ArrayAdapter(getActivity(), android.R.layout.simple_list_item_1, newsHeadlines);

    setListAdapter(adapter);

    newsList.setOnItemClickListener(new OnItemClickListener() {
        @Override
        public void onItemClick(AdapterView<?> parent, View view,
                  int position, long id) {
            Log.i("debug", "single click");
        }
    });

    dbConn.close();

    getActivity().registerReceiver(updateReciever, new IntentFilter("ArticlesUpdated"));
    return newsList;
}
}

What is it, I'm doing wrong?

Thanks a lot in advance!

score 35 · Accepted Answer · answered Dec 29 '12 at 09:34

35

If you are using ListFragment then you can simply use its override method onListItemClick()

@Override
    public void onListItemClick(ListView l, View v, int position, long id) {
        // TODO Auto-generated method stub
        super.onListItemClick(l, v, position, id);
    }

answered Dec 29 '12 at 09:34

Lalit Poptani

65,659
21
155
238

1

Yes. Figured that out but couldn't reply to my own question. (See comment on below post). But thanks a lot anyway! :) – dthomasen Dec 29 '12 at 09:38
1

Yay! Finally something that worked! I've spent the past half an hour looking for a solution, and this was it! Thanks! – cnfw Mar 03 '14 at 19:09
1

saved me ! in my case – kuldeep May 20 '15 at 10:25

Nandha · Answer 2 · 2013-04-17T04:19:16.760

15

It is due to custom list item. The default focus is with custom list item (button/textview). It causes this issue.

Please add android:descendantFocusability="blocksDescendants" in root layout of list element. Hope this will help someone.

edited Apr 17 '13 at 04:19

answered Mar 27 '13 at 06:53

Nandha

6,622
2
21
33

score 0 · Answer 3 · answered Dec 29 '12 at 09:25

0

change setListAdapter(adapter); to newsList.setAdapter(adapter);

answered Dec 29 '12 at 09:25

confucius

12,529
10
45
66

Hmm.. Still not working. But I bet that this was an error too. Thanks! – dthomasen Dec 29 '12 at 09:29
2

Figured it out myself :) The solution was to override onListItemClick from ListFragment :) Can't answer because of to low reputation though. – dthomasen Dec 29 '12 at 09:34

score 0 · Answer 4 · answered Jan 24 '15 at 12:52

If you wanted to create or re-use or an existing handler that implements AdapterView.OnItemClickListener, rather than implementing onListItemClick() within the ListFragment, you can do so by getting a reference to the ListView of the ListFragment and setting its listener. In your ListFragment.onResume() you could do:

@Override
public void onResume() {
    super.onResume();
    ListView listView = getListView();
    listView.setOnItemClickListener(new AdapterView.OnItemClickListener() {
        @Override
        public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
            Log.d("TAG", "Stop touching me");
        }
    });
}

In my case, I can use the same listener from an Activity with a ListView, a ListActivity or a ListFragment, e.g.

listView.setOnItemClickListener(new MyListViewOnClickListener(getActivity()));

ListFragment onItemClickListener not working

4 Answers4

Linked