UIActionSheet cancel button strange behaviour

Question

I have a UIBarButtonItem opening an action sheet to offer users choices about what to do. Everything works as expected unless I try to click on the "Cancel" button. The target of the button appears to have moved up from where it should be. I can only activate it by clicking somewhere in the middle of the "Cancel" and "Ok" buttons.

I've tried at action sheets in other applications and they work fine, so it's not just my big thumb. The action sheet is opening in a UIViewController

- (void)showOpenOptions
{
    UIActionSheet *sheet = [[UIActionSheet alloc] 
    initWithTitle:NSLocalizedString(@"Open link in external application?", @"Open in external application")
    delegate:self
    cancelButtonTitle:NSLocalizedString(@"Cancel", @"Cancel")
    destructiveButtonTitle:NSLocalizedString(@"Open Link", @"Open Link")
    otherButtonTitles:nil];

    [sheet showInView:self.view];
    [sheet release];
}

On an unrelated note, I was told at WWDC during an Apple UI review session that the red button on Action Sheets is really intended for 'destructive' actions (i.e. 'delete'). — Ramin, Jul 29 '09 at 17:35
Yeah, I read the human interface guidelines recently and saw that. Changed it from red to grey. — nevan king, Jul 30 '09 at 00:56

nevan king · Accepted Answer · 2014-08-24T13:07:21.020

190

Instead of passing the current view controller's view to the action sheet, use the showFromTabBar: method of UIActionSheet.

The Right Way
This will give the correct tappable area:

[actionSheet showFromTabBar:self.tabBarController.tabBar];

The Wrong Way
This will put the tappable area in the wrong place (if you're using a tab bar or toolbar):

[actionSheet showInView:self.view];

If you're using a toolbar, use the showFromToolbar: method instead. You'll need a reference to the toolbar, most likely an ivar

[actionSheet showFromToolbar:self.myToolbar];

My Old Answer Also works, but is hacky:

Just found a possible answer:

01-Dec-2008 10:22 PM Tom Saxton: I looked at this bug some more, and it seems to be an issue with the tabbar.

If you call UIActionSheet's [sheet showInView:self.view] from a view controller that is a child of a UITabViewController, then the hit testing on the cancel button fails in that portion of the UIActionSheet that lies above the tabbar's view.

If you instead pass in the UITabBarController's view, then the UIActionSheet acts as expected.

NOTE: in iPhone OS 2.1 and earlier, the UIActionSheet came up from the top of the tab bar when you pass the child view, but in 2.2, it comes up from the bottom of the tab bar, and thus covers the tab view.

http://openradar.appspot.com/6410780

Edit: It works correctly when I change the view to be the tab bar's view

[sheet showInView:self.parentViewController.tabBarController.view];

edited Aug 24 '14 at 13:07

answered Jul 29 '09 at 02:22

nevan king

108,735
42
196
237

Upvoted this because it works. Why is this better than the other answers? – bentford Aug 26 '09 at 02:45
1

Why the parentViewController? Even if the view is in a navigationview tabBarController should still point to the right place. Works for me without the parentViewController in any case. – Nathan Sep 30 '10 at 10:48
11

Another answer seems potentially better. Look for [actionSheet showInView:[self.view window]]. Seems more straight forward and more generic. – Kevin Oct 20 '10 at 22:37
Thank you so much for posting this answer. – fulvio Nov 30 '10 at 06:23
Thank you works good, although parentViewController is not required. – Oscar Gomez Oct 26 '11 at 13:26
1

I don't have tab bar in my app, but still have such problem. I solved it with '[serf.view window]'. It is not tab bar problem anyway. – Mike Keskinov Feb 24 '12 at 14:09
Upvoted but i still have issues with that target area problem.The cancel button now works fine for me though. – Pradeep Mittal Oct 29 '13 at 10:03

score 37 · Answer 2 · edited May 23 '17 at 12:09

37

I found an answer over here that works.

using: [filterActionSheet showInView:[self.view window]];

i tried a few ways to get to my tab bar and they way this app is set up it seem convoluted...

edited May 23 '17 at 12:09

Community

1
1

answered Jul 29 '09 at 02:38

driveguy

793
1
9
14

PERFECT! Thanks. This is the correct solution for me, as I was having this issue with a UITableViewController that had a toolbar *not* a TabBar like others here. – William Denniss May 14 '10 at 08:09
good stuff, this worked for me! this is definitely the easiest way to do it! – Christian Gossain Nov 07 '11 at 06:52
2

It cause another problem. ActionSheet appears in portrait orientation when device in landscape (as well as all other content). – Mike Keskinov Apr 10 '12 at 19:38

score 22 · Answer 3 · edited Feb 22 '10 at 22:20

22

Instead use:

[sheet showFromTabBar:theTabBar];

edited Feb 22 '10 at 22:20

Stephen Darlington

49,617
11
101
147

answered Jul 29 '09 at 03:01

Corey Floyd

25,769
30
123
152

1

I corrected this from `showInTabBar:` to `showFromTabBar:`. Also note that there's a 'showFromToolbar:` method, depending on what screen furniture you have at the bottom of the screen. This, I think, is a better answer than the accepted answer. – Stephen Darlington Feb 22 '10 at 22:22
Stephen, curious why you think this is better than specifying showInView:theTabBar? From a coupling perspective I'd think that showInView would probably be more ideal, in case later on the tabBar is dropped, maybe replaced with a toolbar, for instance. The particular sub view controller shouldn't really have to know or care, I'd think. – Billy Gray May 07 '10 at 19:12
If the tab bar is dropped later, you're going to have to edit that line of code regardless (unless perhaps theTabBar is a poorly-named reference to a view that's passed in). So I don't see how this method is any more coupled than showInView:theTabBar. I use showFromTabBar: as well, as it seems safer to me. I don't know what's going on under the covers, but I imagine that showFromTabBar: is less likely to break in future OS releases than showFromView: with a tab bar view. – Christopher Pickslay Jun 16 '10 at 23:50

score 10 · Answer 4 · edited Apr 18 '12 at 10:38

10

Here is the fix.Try this:

[actionsheet showInView:[UIApplication sharedApplication].keyWindow];

edited Apr 18 '12 at 10:38

Akshay Aher

2,495
2
16
33

answered Jan 09 '12 at 17:48

Viggnesh

237
2
5

score 5 · Answer 5 · answered Nov 24 '11 at 16:19

5

I think a combination of three of the answers is the right way of handling this:

    [actionSheet showFromTabBar:self.tabBarController.tabBar];

i.e., use showFromTabBar (that's why it exists) and you don't need the parentViewController as Nathan pointed out (in fact, self.parentViewController.tabBarController.tabBar returns nil for me.

answered Nov 24 '11 at 16:19

RawMean

7,547
3
52
79

Of course it returns nil, because the parent view controller (which is the UITabBarViewController) isn't nested itself into another UITabBarController, so its tabBarController-property is nil. – Dominik Seibold Dec 24 '11 at 10:40

score 1 · Answer 6 · answered Aug 27 '10 at 14:30

FYI - had the same problem with UIDocumentInteractionController's actionsheet stepping on the tabbar. Used the following to fix.

UIViewController *parentView = [[self parentViewController] parentViewController];
[docController presentOptionsMenuFromRect: rect inView: parentView.view animated:YES];

score -2 · Answer 7 · edited Dec 26 '15 at 06:51

-2

write simplite code

 actionSheet.actionSheetStyle = UIActionSheetStyleDefault;

this work fine

edited Dec 26 '15 at 06:51

Pang

8,605
144
77
113

answered Jul 04 '12 at 11:26

jayesh kavathiya

3,507
2
20
25

UIActionSheet cancel button strange behaviour

7 Answers7

Linked