50

Following is my code:

test = 'abc'
if True:
    raise test + 'def'

And when i run this, it gives me the TypeError

TypeError: exceptions must be old-style classes or derived from BaseException, not str

So what kind of type should the test be?

2342G456DI8
  • 1,729
  • 2
  • 14
  • 29

3 Answers3

64

The sole argument to raise indicates the exception to be raised. This must be either an exception instance or an exception class (a class that derives from Exception).

Try this:

test = 'abc'
if True:
    raise Exception(test + 'def')
36

You can't raise a str. Only Exceptions can be raised.

So, you're better off constructing an exception with that string and raising that. For example, you could do:

test = 'abc'
if True:
    raise Exception(test + 'def')

OR

test = 'abc'
if True:
    raise ValueError(test + 'def')

Hope that helps

inspectorG4dget
  • 97,394
  • 22
  • 128
  • 222
17

It should be an exception.

You want to do something like:

raise RuntimeError(test + 'def')

In Python 2.5 and below, your code would work, as then it was allowed to raise strings as exceptions. This was a very bad decision, and so removed in 2.6.

Abe Karplus
  • 7,360
  • 2
  • 23
  • 24
  • 2
    Could you explain why it is so bad to raise a string as an exception? – BioGeek Jun 05 '13 at 08:08
  • 3
    @BioGeek Problems with string exceptions include only sometimes working when a literal is used in both the `raise` and the `except`, not providing an OO mechanism for attaching additional information to the exception, and not allowing catching categories of multiple exception types. Exceptions were added to the language before classes, and once exception classes were added string exceptions were only kept for backwards compatibility. Their removal, like any (mis-)feature removal, simplified the language. – Abe Karplus Jun 05 '13 at 16:05
  • 1
    Thanks for mentioning the version where this feature was last supported. That helped me. – SpaceTrucker Jul 29 '13 at 13:19