cin.getline() is skipping an input in C++

Question

If I use the following code, getline doesn't take the last input(for last iteration of "for" loop, it simply skips it) -

int main()
{
    int n;
    map<string, set<string> > lst;
    string c,s,c2;

    cin>>n;

    for(int i=0;i<n;i++)
    {
            getline(cin,c); // here it skips the input for last iteration
            stringstream ss;
            ss<<c;

            bool f=1;
            while(ss>>s)
            {
                        if(f)
                        {
                             c2=s;
                             f=0;
                        }
                        else
                             lst[c2].insert(s);           
            }
    }

    for (map<string, set<string> >::const_iterator ci = lst.begin(); ci != lst.end(); ++ci)
    {
                cout<< (*ci).first <<" "<< (*ci).second.size() <<endl;
    }
}

To get rid of it, I put cin.ignore() after getline. Now its taking all the inputs but I'm facing a new issue -

#include<iostream>
#include<string>
#include<map>
#include<set>
#include<sstream>
#include<algorithm>

using namespace std;

int main()
{
    int n;
    map<string, set<string> > lst;
    string c,s,c2;

    cin>>n;

    for(int i=0;i<n;i++)
    {
            getline(cin,c);
            cin.ignore();
            stringstream ss;
            ss<<c;

            bool f=1;
            while(ss>>s)
            {
                        if(f)
                        {
                             c2=s;
                             f=0;
                        }
                        else
                             lst[c2].insert(s);           
            }
    }

    for (map<string, set<string> >::const_iterator ci = lst.begin(); ci != lst.end(); ++ci)
    {
                cout<< (*ci).first <<" "<< (*ci).second.size() <<endl;
    }
}

The new issue is that while taking c2, first character of string gets removed. For example, if I give "England Jane Doe" as input to getline, in c2 I'll get "ngland".

How to get rid of this issue now?

Mixing `>>` and `getline` is delicate. In any case, you never *check* the result of either, so why would you even expect your code to work? — Kerrek SB, Apr 17 '12 at 22:10

score 16 · Accepted Answer · edited Jan 29 '15 at 10:16

16

This:

cin>>n;

Is reading the number only.
It leaves the trailing '\n' on the stream.

So your first call to getline() is reading an empty line containing just a '\n'

It is best not to mix the use of operator>> and std::getline(). You have to be very careful on whether you have left the newline on the stream. I find it easiest to always read a line at a time from a user. Then parse the line separately.

 std::string  numnber;
 std::getline(std::cin, number);

 int n;
 std::stringstream numberline(number);
 numberline >> n;

edited Jan 29 '15 at 10:16

phadej

11,537
36
72

answered Apr 17 '12 at 22:17

Martin York

234,851
74
306
532

Thanks for the nice explanation! :) – theharshest Apr 18 '12 at 08:53

score 2 · Answer 2 · answered Apr 17 '12 at 22:21

2

your cin.ignore() is in the wrong place. getline does not leave the trailing \n newline character, it's the >> symbol which does that.

What you probably want is

cin>>n;
cin.ignore();

answered Apr 17 '12 at 22:21

Ben Cottrell

4,680
1
23
31

1

`cin.ignore` only ignores 1 character, you need to ignore all characters until the `\n` newline character. – alexisdm Apr 17 '12 at 23:04

Rajeev · Answer 3 · 2014-11-22T12:30:37.200

1

actually the cin buffer has \n remaining from last cin, so getline take this \n character and gets terminated; ignore the content of buffer before getline...

cin.ignore();

getling(cin, string_name);

//it will work smoothly

edited Nov 22 '14 at 12:30

answered Nov 02 '14 at 11:32

Rajeev

21
2

score 0 · Answer 4 · answered Jun 22 '14 at 06:23

0

just write

cin.ignore();

after your last ">>" operator. ">>" operator leaves a newline "\n" in the input bitstream which needs to be cleared before taking the inputs.

answered Jun 22 '14 at 06:23

Vikas Kalwani

23
7

cin.getline() is skipping an input in C++

4 Answers4

Linked

Related